🧑💻 login command - print selected username to avoid ambiguity #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeralight
force-pushed
the
login-print-username
branch
from
7534c2f
to
a496e21
Compare
This will help preventing an unexpected username saved in the store. The behaviour is similar to most cli apps: ``` $ cl login Please enter your user name [default_user_name]: user_input ``` If the user enters empty string, then `default_user_name` is used instead of `user_input`.
zeralight
force-pushed
the
login-print-username
branch
from
944bc69
to
dc8e6ae
Compare
bhou
requested changes
Aug 1, 2024
bhou
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the default username picked up by the tool isn't printed and in some cases the selected one is not the expected one by the user.
this PR addresses the ambiguity by printing explicitly the resolved user.
The behaviour is similar to most cli apps:
If the user enters empty string, then
default_user_nameis used instead ofinput_user.